Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platforms] Add stubs for new API in SfpUtilBase to platforms which haven't added #2038

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Sep 12, 2018

- What I did
to fix issue #2017
New API get_transceiver_change_event() introduced to SfpUtilBase, need add stubs to the sfputil plugin of the platforms which haven't implement this methond yet.

- How I did it
add a definiton of get_transceiver_change_event() to the sfputil plugin, in the function it will raise NotImplementedError.

- How to verify it

need each platform to run command to check sfp presence.

- Description for the changelog

Changes to be committed:
(use "git reset HEAD ..." to unstage)

    modified:   accton/x86_64-accton_as5712_54x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7116_54x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7212_54x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7312_54x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7312_54xs-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7326_56x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7512_32x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7712_32x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7716_32x-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7716_32xb-r0/plugins/sfputil.py
    modified:   accton/x86_64-accton_as7816_64x-r0/plugins/sfputil.py
    modified:   centec/x86_64-centec_e582_48x6q-r0/plugins/sfputil.py
    modified:   dell/x86_64-dell_s6000_s1220-r0/plugins/sfputil.py
    modified:   dell/x86_64-dell_s6100_c2538-r0/plugins/sfputil.py
    modified:   dell/x86_64-dellemc_z9264f_c3538-r0/plugins/sfputil.py
    modified:   delta/x86_64-delta_ag5648-r0/plugins/sfputil.py
    modified:   delta/x86_64-delta_ag9032v1-r0/plugins/sfputil.py
    modified:   delta/x86_64-delta_ag9064-r0/plugins/sfputil.py
    modified:   delta/x86_64-delta_et-6248brb-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s8810_32q-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s8900_54xc-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s8900_64xc-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s9100-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s9130_32x-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s9180_32x-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s9200_64x-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s9230_64x-r0/plugins/sfputil.py
    modified:   ingrasys/x86_64-ingrasys_s9280_64x-r0/plugins/sfputil.py
    modified:   inventec/x86_64-inventec_d7032q28b-r0/plugins/sfputil.py
    modified:   inventec/x86_64-inventec_d7054q28b-r0/plugins/sfputil.py
    modified:   inventec/x86_64-inventec_d7264q28b-r0/plugins/sfputil.py
    modified:   marvell/x86_64-marvell_slm5401_54x-r0/plugins/sfputil.py
    modified:   mitac/x86_64-mitac_ly1200_b32h0_c3-r0/plugins/sfputil.py
    modified:   quanta/x86_64-quanta_ix1b_32x-r0/plugins/sfputil.py
    modified:   wnc/x86_64-wnc_osw1800-r0/plugins/sfputil.py

- A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan merged commit ac7e06d into sonic-net:master Sep 12, 2018
@keboliu keboliu deleted the xcvrd_stubs branch September 13, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants