Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia][snmpwalk] Fix the snmpwalk cefcFruPowerStatusTable on Nokia LC platform #19733

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mlok-nokia
Copy link
Contributor

Why I did it

Executes "docker exec -it snmp snmpwalk -v2c -c 127.0.0.1 1.3.6.1.4.1.9.9.117.1.1.2.1" Nokia LC - Nokia_IXR7250E_36x400G will get the following error in the syslog:
Jul 30 02:03:21.836386 ixre-egl-board9 ERR snmp#snmp-subagent [sonic_ax_impl] ERROR: PowerStatusHandler._get_psu_index() caught an unexpected exception during _get_num_psus()#012Traceback (most recent call last):#12 File "/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/vendor/cisco/ciscoEntityFruControlMIB.py", line 101, in _get_psu_index#012 num_psus = self._get_num_psus()#12 File "/usr/local/lib/python3.9/dist-packages/sonic_ax_impl/mibs/vendor/cisco/ciscoEntityFruControlMIB.py", line 66, in _get_num_psus#012 return int(num_psus[0])#012ValueError: invalid literal for int() with base 10: ''

This PR will enable to Psud in LC to address this issue. Fixes #19535

Work item tracking
  • Microsoft ADO (number only):

How I did it

Based on the snmp_agent common handling, it requires to enable the Pusd on the LC to set the "psu_num": 0 (as in the below entry) to allow the mibwalk handle the return value correctly. Enable the Psud on the LC although there is no PSU in LC.  

How to verify it

  1. Executes "docker exec -it snmp snmpwalk -v2c -c 127.0.0.1 1.3.6.1.4.1.9.9.117.1.1.2.1"
  2. Check the syslog, there should not any error in the syslog which is related to this MIBwalk.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

  • master
  • 202405

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@SuvarnaMeenakshi
Copy link
Contributor

/azp run

Copy link

Commenter does not have sufficient privileges for PR 19733 in repo sonic-net/sonic-buildimage

@SuvarnaMeenakshi SuvarnaMeenakshi added Request for 202405 Branch Chassis for 202205 branch PRs needed for 202205 branch in msft repo labels Aug 7, 2024
@SuvarnaMeenakshi
Copy link
Contributor

@judyjoseph @rlhui can you help approve and merge this PR.

@rlhui
Copy link
Contributor

rlhui commented Aug 14, 2024

@judyjoseph @rlhui can you help approve and merge this PR.

ms_Checker failing

@rlhui
Copy link
Contributor

rlhui commented Aug 21, 2024

/ms_checker

@judyjoseph
Copy link
Contributor

/azpw ms_checker -f

@abdosi
Copy link
Contributor

abdosi commented Aug 28, 2024

@qiluo-msft : please help with merge of this.

@rlhui rlhui merged commit 8dcf192 into sonic-net:master Aug 28, 2024
22 checks passed
@SuvarnaMeenakshi
Copy link
Contributor

MS ADO : 27241572

@mlok-nokia
Copy link
Contributor Author

@SuvarnaMeenakshi @qiluo-msft Please don't cherry-pick this PR to 202205 branch. Takes this change to 202205 branch will require other PR to be cherry-pick to the Nokia 202205 sonic_platform submodule

@SuvarnaMeenakshi
Copy link
Contributor

@SuvarnaMeenakshi @qiluo-msft Please don't cherry-pick this PR to 202205 branch. Takes this change to 202205 branch will require other PR to be cherry-pick to the Nokia 202205 sonic_platform submodule

@mlok-nokia do you know what is the list of PRs that is required in Nokia 202205 sonic_platform submodule?

@SuvarnaMeenakshi
Copy link
Contributor

don't cherry-pick this PR to 202205 branch. Takes this change to 202205 branch will require other PR to be cherry-pick to the Nokia 202205 sonic_platform submodule

@mlok-nokia Can you help share list of PRs that is required in 202205 to ensure that this can be cherry-picked for 202205?

@mlok-nokia
Copy link
Contributor Author

don't cherry-pick this PR to 202205 branch. Takes this change to 202205 branch will require other PR to be cherry-pick to the Nokia 202205 sonic_platform submodule

@mlok-nokia Can you help share list of PRs that is required in 202205 to ensure that this can be cherry-picked for 202205?

Cherry-pick this PR to 202205 requires to merge PR Azure/sonic-buildimage-msft#449

@SuvarnaMeenakshi
Copy link
Contributor

don't cherry-pick this PR to 202205 branch. Takes this change to 202205 branch will require other PR to be cherry-pick to the Nokia 202205 sonic_platform submodule

@mlok-nokia Can you help share list of PRs that is required in 202205 to ensure that this can be cherry-picked for 202205?

Cherry-pick this PR to 202205 requires to merge PR sonic-net/sonic-buildimage-msft#449

Thank you @mlok-nokia , I see that the above change is already present in 202205 branch. So we should be good, as long as this is the only dependent PR.

@mlok-nokia
Copy link
Contributor Author

don't cherry-pick this PR to 202205 branch. Takes this change to 202205 branch will require other PR to be cherry-pick to the Nokia 202205 sonic_platform submodule

@mlok-nokia Can you help share list of PRs that is required in 202205 to ensure that this can be cherry-picked for 202205?

Cherry-pick this PR to 202205 requires to merge PR sonic-net/sonic-buildimage-msft#449

Thank you @mlok-nokia , I see that the above change is already present in 202205 branch. So we should be good, as long as this is the only dependent PR.

This is the only dependency. PR Azure/sonic-buildimage-msft#449 is to update the submodule on 202205 branch to pick the change to work with this PR.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 6, 2024
…C platform (sonic-net#19733)

Executes "docker exec -it snmp snmpwalk -v2c -c 127.0.0.1 1.3.6.1.4.1.9.9.117.1.1.2.1" Nokia LC - Nokia_IXR7250E_36x400G will get error in the syslog.
This PR will enable  Psud in LC to address this issue. Fixes sonic-net#19535
Signed-off-by: mlok <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20181

mssonicbld pushed a commit that referenced this pull request Sep 7, 2024
…C platform (#19733)

Executes "docker exec -it snmp snmpwalk -v2c -c 127.0.0.1 1.3.6.1.4.1.9.9.117.1.1.2.1" Nokia LC - Nokia_IXR7250E_36x400G will get error in the syslog.
This PR will enable  Psud in LC to address this issue. Fixes #19535
Signed-off-by: mlok <[email protected]>
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024
…C platform (sonic-net#19733)

Executes "docker exec -it snmp snmpwalk -v2c -c 127.0.0.1 1.3.6.1.4.1.9.9.117.1.1.2.1" Nokia LC - Nokia_IXR7250E_36x400G will get error in the syslog.
This PR will enable  Psud in LC to address this issue. Fixes sonic-net#19535
Signed-off-by: mlok <[email protected]>
@mlok-nokia mlok-nokia deleted the snmp_mib_walk branch September 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

psu_num missing in STATE_DB CHASSIS_INFO table of Chassis Linecard
7 participants