Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/dell] Update Shared headroom values #1846

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

vharish02
Copy link
Contributor

This commit updates the shared headroom value for z9100
T0 and T1 profile based on the ratio. The ratio is derived
from the 40G broadcom recommended XL Sheet.
Unit tested the above configuration by dumping the registers
for the shared headroom. The shared headroom values in registers
reflects the correct new values for both T1 and T0.

Signed-off-by: Harish Venkatraman [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This commit updates the shared headroom value for z9100
T0 and T1 profile based on the ratio. The ratio is derived
from the 40G broadcom recommended XL Sheet.
Unit tested the above configuration by dumping the registers
for the shared headroom. The shared headroom values in registers
reflects the correct new values for both T1 and T0.

Signed-off-by: Harish Venkatraman <[email protected]>
@vharish02
Copy link
Contributor Author

@yxieca Can you please review the changes. These are the shared headroom changes which was agreed on the last call.

@yxieca yxieca merged commit a0bd656 into sonic-net:master Jul 10, 2018
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
What I did
These format are not wrong. But if error_handler for $? is installed, these places would cause fase positives.

How I did it
Update more bash syntax to avoid false positives

How to verify it
Run show tech support test before merge.

Signed-off-by: Ying Xie [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants