[action] [PR:17092] [mlnx-fw-upgrade] Add FW reactivation in case 2 FW upgrades were done without reboot #17286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without reboot (sonic-net#17092) - Why I did it In order to activate FW after it was upgraded need to perform reboot. If reboot wasn't performed and user need to upgrade to another SONiC image then it will fail. The reason for that is that during SONiC upgrade new FW should be installed but it will fail because previously installed FW wasn't activated. In order to allow 2nd FW upgrade without reboot in-between need to reactivate FW image. This change handles such flow. Example of issue scenario: User installed SONiC image on the switch Then for some reason FW was upgraded by user or script but reboot was not performed to activate it. After that upgrade to new SONiC image will fail because new image need to install FW but it fails due to previous one wasn't activated. - How I did it In "mlnx-fw-upgrade" script check if FW upgrade failed with the error that FW was already installed but reboot was not performed. If so then perform FW image reactivation and try to upgrade FW again. - How to verify it Install SONiC image on the switch Then upgrade FW but don't perform reboot. After that upgrade to new SONiC image and check that upgrade was successfull. Signed-off-by: Volodymyr Samotiy <[email protected]>
11 tasks
|
Original PR: #17092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In order to activate FW after it was upgraded need to perform reboot.
If reboot wasn't performed and user need to upgrade to another SONiC image then it will fail.
The reason for that is that during SONiC upgrade new FW should be installed but it will fail because previously installed FW wasn't activated.
In order to allow 2nd FW upgrade without reboot in-between need to reactivate FW image.
This change handles such flow.
Example of issue scenario:
Work item tracking
How I did it
In "mlnx-fw-upgrade" script check if FW upgrade failed with the error that FW was already installed but reboot was not performed.
If so then perform FW image reactivation and try to upgrade FW again.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
[mlnx-fw-upgrade] Add FW reactivation in case 2 FW upgrades were done without reboot
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)