Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snappi] Update snappi module on sonic-mgmt docker #17269

Merged

Conversation

developfast
Copy link
Contributor

Why I did it

Updating snappi and all relevant modules to the latest stable version for security updates.

Work item tracking
  • Microsoft ADO (number only): 25936875

How I did it

How to verify it

Snappi tests are running with this version of snappi with the appropriate lag port changes.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@developfast developfast requested a review from lguohan as a code owner November 22, 2023 19:26
@developfast developfast changed the title Update snappi module on Dockerfile.j2 [Snappi] Update snappi module on Dockerfile.j2 Nov 22, 2023
@developfast developfast changed the title [Snappi] Update snappi module on Dockerfile.j2 [Snappi] Update snappi module on sonic-mgmt docker Nov 22, 2023
Copy link
Contributor

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developfast
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 17269 in repo sonic-net/sonic-buildimage

@developfast
Copy link
Contributor Author

/azpw run Azure.docker-sonic-mgmt

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.docker-sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@developfast
Copy link
Contributor Author

/azpw run Azure.docker-sonic-mgmt-python3-only

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.docker-sonic-mgmt-python3-only

Copy link

No pipelines are associated with this pull request.

@developfast
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@developfast
Copy link
Contributor Author

/azpw run Azure.docker-sonic-mgmt-python3-only

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.docker-sonic-mgmt-python3-only

Copy link

No pipelines are associated with this pull request.

@yxieca
Copy link
Contributor

yxieca commented Dec 1, 2023

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@yxieca
Copy link
Contributor

yxieca commented Dec 1, 2023

/azp run Azure.docker-sonic-mgmt-python3-only

Copy link

No pipelines are associated with this pull request.

@xumia
Copy link
Collaborator

xumia commented Dec 1, 2023

/azp Azure.sonic-buildimage

Copy link

Command 'Azure.sonic-buildimage' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@xumia
Copy link
Collaborator

xumia commented Dec 1, 2023

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia
Copy link
Collaborator

xumia commented Dec 1, 2023

/azp run Azure.docker-sonic-mgmt-python3-only

Copy link

No pipelines are associated with this pull request.

@yxieca yxieca merged commit 19b2164 into sonic-net:master Dec 1, 2023
12 of 19 checks passed
yxieca pushed a commit that referenced this pull request Dec 4, 2023
* Update snappi module on Dockerfile.j2

* Update snappi module on Dockerfile.j2

* Update snappi module for py2 and venv
@mssonicbld
Copy link
Collaborator

@developfast PR conflicts with 202305 branch

@StormLiangMS
Copy link
Contributor

@developfast could you file separate PR for 202305?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants