Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] CMIS management feature enablement #16968

Merged

Conversation

dbarashinvd
Copy link
Contributor

@dbarashinvd dbarashinvd commented Oct 23, 2023

Depends on #18571

Why I did it

CMIS management feature enablement

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add new variable with value 1 for CMIS management feature enablement under specific HWSKU folder. Not the default one

How to verify it

Install image on switch with same HWSKU and check "show interfaces status" (Type column)

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dbarashinvd dbarashinvd marked this pull request as draft October 23, 2023 09:23
@keboliu keboliu requested a review from prgeor November 13, 2023 10:38
prgeor
prgeor previously approved these changes Dec 1, 2023
@liat-grozovik
Copy link
Collaborator

@dbarashinvd please add also recent added SKU to this PR done by @DavidZagury.

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment below

@dbarashinvd
Copy link
Contributor Author

see comment below

working on it. cant get the new SKU folder for update after fetch and rebase. will sort it out and update

@dbarashinvd
Copy link
Contributor Author

@dbarashinvd please add also recent added SKU to this PR done by @DavidZagury.

done

@prgeor
Copy link
Contributor

prgeor commented Jan 16, 2024

@liat-grozovik @dbarashinvd please see if this can be moved out of draft and unblocked?

@prgeor
Copy link
Contributor

prgeor commented Apr 4, 2024

@moshemos @liat-grozovik @keboliu What is pending for this to be enabled?

@zhangyanzhao zhangyanzhao changed the title CMIS management feature enablement for MSFT HWSKU CMIS management feature enablement Apr 4, 2024
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 5, 2024 via email

@liat-grozovik liat-grozovik marked this pull request as ready for review April 7, 2024 14:04
@prgeor
Copy link
Contributor

prgeor commented Apr 12, 2024

@liat-grozovik can you please merge?

@liat-grozovik liat-grozovik changed the title CMIS management feature enablement [Mellanox] CMIS management feature enablement Apr 14, 2024
@liat-grozovik liat-grozovik merged commit c75c82c into sonic-net:master Apr 14, 2024
19 checks passed
@noaOrMlnx
Copy link
Collaborator

@yxieca can you please cherry-pick to 202311?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 16, 2024
- Why I did it
CMIS management feature enablement

- How I did it
Add new variable with value 1 for CMIS management feature enablement under specific HWSKU folder. Not the default one

- How to verify it
Install image on switch with same HWSKU and check "show interfaces status" (Type column)
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #18982

mssonicbld pushed a commit that referenced this pull request May 17, 2024
- Why I did it
CMIS management feature enablement

- How I did it
Add new variable with value 1 for CMIS management feature enablement under specific HWSKU folder. Not the default one

- How to verify it
Install image on switch with same HWSKU and check "show interfaces status" (Type column)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants