-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YANG model for FABRIC_PORT #15629
Merged
qiluo-msft
merged 4 commits into
sonic-net:master
from
kenneth-arista:master-yang-model-for-fabric-port
Jul 3, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
42a73c0
Add YANG model for FABRIC_PORT
jfeng-arista 00609a5
Added default value for isolateStatus, add mandatory for lanes field.
jfeng-arista 6da5435
Add description to the leaf nodes.
jfeng-arista 3be1170
Used boolean_type instead of string for isolateStatus
kenneth-arista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
src/sonic-yang-models/tests/yang_model_tests/tests/fabric_port.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"FABRIC_PORT_POSITIVE_CONFIG": { | ||
"desc": "Configure FABRIC_PORT no failure." | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
src/sonic-yang-models/tests/yang_model_tests/tests_config/fabric_port.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"FABRIC_PORT_POSITIVE_CONFIG": { | ||
"sonic-fabric-port:sonic-fabric-port": { | ||
"sonic-fabric-port:FABRIC_PORT": { | ||
"FABRIC_PORT_LIST": [ | ||
{ | ||
"name": "Fabric0", | ||
"alias": "Fabric0", | ||
"isolateStatus": "False", | ||
"lanes": "0" | ||
} | ||
] | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
module sonic-fabric-port{ | ||
|
||
yang-version 1.1; | ||
|
||
namespace "https://github.com/sonic-net/sonic-fabric-port"; | ||
prefix fabric-port; | ||
|
||
description "FABRIC_PORT yang Module for SONiC OS"; | ||
|
||
revision 2023-03-14 { | ||
description "First Revision"; | ||
} | ||
|
||
container sonic-fabric-port { | ||
|
||
container FABRIC_PORT { | ||
|
||
description "FABRIC_PORT part of config_db.json"; | ||
|
||
list FABRIC_PORT_LIST { | ||
|
||
key "name"; | ||
|
||
leaf name { | ||
type string { | ||
length 1..128; | ||
} | ||
} | ||
|
||
leaf isolateStatus { | ||
description "Isolation status of a fabric port"; | ||
type string { | ||
pattern "False|True"; | ||
} | ||
default "False"; | ||
} | ||
|
||
leaf alias { | ||
description "Alias of a fabric port"; | ||
type string { | ||
length 1..128; | ||
} | ||
} | ||
|
||
leaf lanes { | ||
description "Lanes of a fabric port"; | ||
mandatory true; | ||
type string { | ||
length 1..128; | ||
} | ||
} | ||
|
||
} /* end of list FABRIC_PORT_LIST */ | ||
|
||
} /* end of container FABRIC_PORT */ | ||
|
||
} /* end of container sonic-fabric-port */ | ||
|
||
} /* end of module sonic-fabric-port */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use Boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. I will revise it to use
type stypes:boolean_type
where stypes is sonic-types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. See latest commit. I'm waiting for the pipeline build to complete to check if any further revisions are needed.