Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dell S6100]: EEPROM plugin overrides serial_number_str() to return service tag instead of serial number #1239

Merged
merged 2 commits into from
Dec 15, 2017
Merged

[Dell S6100]: EEPROM plugin overrides serial_number_str() to return service tag instead of serial number #1239

merged 2 commits into from
Dec 15, 2017

Conversation

jleveque
Copy link
Contributor

No description provided.

@jleveque jleveque self-assigned this Dec 14, 2017
@jleveque jleveque requested a review from lguohan December 14, 2017 23:10
@lguohan lguohan merged commit 1c0c3ff into sonic-net:master Dec 15, 2017
@jleveque jleveque deleted the 6100_eeprom_fix branch December 19, 2017 00:51
@dzhangalibaba dzhangalibaba mentioned this pull request Apr 20, 2020
Merged
@judyjoseph judyjoseph mentioned this pull request Apr 25, 2020
Merged
abdosi added a commit that referenced this pull request Jun 16, 2020
@abdosi
[Submodule update] sonic-swss
96a8e24 
Revert "[portsorch] Enable port-level buffer drop counters (#1237)"
(#1308) Add more log message, fix test code (#1239)
@jleveque jleveque mentioned this pull request Nov 18, 2020
Merged
jleveque added a commit that referenced this pull request Nov 25, 2020
@jleveque
[sonic-utilities] Update submodule; Build and install as a Python 3 w…
7f4ab8f 
…heel (#5926)

Submodule updates include the following commits:

* src/sonic-utilities 9dc58ea...f9eb739 (18):
  > Remove unnecessary calls to str.encode() now that the package is Python 3; Fix deprecation warning (#1260)
  > [generate_dump] Ignoring file/directory not found Errors (#1201)
  > Fixed porstat rate and util issues (#1140)
  > fix error: interface counters is mismatch after warm-reboot (#1099)
  > Remove unnecessary calls to str.decode() now that the package is Python 3 (#1255)
  > [acl-loader] Make list sorting compliant with Python 3 (#1257)
  > Replace hard-coded fast-reboot with variable. And some typo corrections (#1254)
  > [configlet][portconfig] Remove calls to dict.has_key() which is not available in Python 3 (#1247)
  > Remove unnecessary conversions to list() and calls to dict.keys() (#1243)
  > Clean up LGTM alerts (#1239)
  > Add 'requests' as install dependency in setup.py (#1240)
  > Convert to Python 3 (#1128)
  > Fix mock SonicV2Connector in python3: use decode_responses mode so caller code will be the same as python2 (#1238)
  > [tests] Do not trim from PATH if we did not append to it; Clean up/fix shebangs in scripts (#1233)
  > Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (#1224)
  > [cli]: NAT show commands newline issue after migrated to Python3 (#1204)
  > [doc]: Update Command-Reference.md (#1231)
  > Added 'import sys' in feature.py file (#1232)

* src/sonic-py-swsssdk 9d9f0c6...1664be9 (2):
  > Fix: no need to decode() after redis client scan, so it will work for both python2 and python3 (#96)
  > FieldValueMap `contains`(`in`)  will also work when migrated to libswsscommon(C++ with SWIG wrapper) (#94)

- Also fix Python 3-related issues:
    - Use integer (floor) division in config_samples.py (sonic-config-engine)
    - Replace print statement with print function in eeprom.py plugin for x86_64-kvm_x86_64-r0 platform
    - Update all platform plugins to be compatible with both Python 2 and Python 3
    - Remove shebangs from plugins files which are not intended to be executable
    - Replace tabs with spaces in Python plugin files and fix alignment, because Python 3 is more strict
    - Remove trailing whitespace from plugins files
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
@qiluo-msft @abdosi
Add more log message, fix test code (sonic-net#1239)
a153622
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@jleveque @santhosh-kt
[sonic-utilities] Update submodule; Build and install as a Python 3 w…
8d48e6f 
…heel (sonic-net#5926)

Submodule updates include the following commits:

* src/sonic-utilities 9dc58ea...f9eb739 (18):
  > Remove unnecessary calls to str.encode() now that the package is Python 3; Fix deprecation warning (sonic-net#1260)
  > [generate_dump] Ignoring file/directory not found Errors (sonic-net#1201)
  > Fixed porstat rate and util issues (sonic-net#1140)
  > fix error: interface counters is mismatch after warm-reboot (sonic-net#1099)
  > Remove unnecessary calls to str.decode() now that the package is Python 3 (sonic-net#1255)
  > [acl-loader] Make list sorting compliant with Python 3 (sonic-net#1257)
  > Replace hard-coded fast-reboot with variable. And some typo corrections (sonic-net#1254)
  > [configlet][portconfig] Remove calls to dict.has_key() which is not available in Python 3 (sonic-net#1247)
  > Remove unnecessary conversions to list() and calls to dict.keys() (sonic-net#1243)
  > Clean up LGTM alerts (sonic-net#1239)
  > Add 'requests' as install dependency in setup.py (sonic-net#1240)
  > Convert to Python 3 (sonic-net#1128)
  > Fix mock SonicV2Connector in python3: use decode_responses mode so caller code will be the same as python2 (sonic-net#1238)
  > [tests] Do not trim from PATH if we did not append to it; Clean up/fix shebangs in scripts (sonic-net#1233)
  > Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (sonic-net#1224)
  > [cli]: NAT show commands newline issue after migrated to Python3 (sonic-net#1204)
  > [doc]: Update Command-Reference.md (sonic-net#1231)
  > Added 'import sys' in feature.py file (sonic-net#1232)

* src/sonic-py-swsssdk 9d9f0c6...1664be9 (2):
  > Fix: no need to decode() after redis client scan, so it will work for both python2 and python3 (sonic-net#96)
  > FieldValueMap `contains`(`in`)  will also work when migrated to libswsscommon(C++ with SWIG wrapper) (sonic-net#94)

- Also fix Python 3-related issues:
    - Use integer (floor) division in config_samples.py (sonic-config-engine)
    - Replace print statement with print function in eeprom.py plugin for x86_64-kvm_x86_64-r0 platform
    - Update all platform plugins to be compatible with both Python 2 and Python 3
    - Remove shebangs from plugins files which are not intended to be executable
    - Replace tabs with spaces in Python plugin files and fix alignment, because Python 3 is more strict
    - Remove trailing whitespace from plugins files
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@jleveque
Clean up LGTM alerts (sonic-net#1239)
1c45ca1 
Clean up some alerts which were detected by LGTM tool
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@qiluo-msft
Add more log message, fix test code (sonic-net#1239)
8df99da
@ArunSaravananBalachandran ArunSaravananBalachandran mentioned this pull request Dec 7, 2023
Merged
9 tasks
lguohan pushed a commit that referenced this pull request Dec 7, 2023
@ArunSaravananBalachandran
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
80e7437 
…tag instead of serial number (#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: #1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
@mssonicbld mssonicbld mentioned this pull request Dec 13, 2023
Merged
9 tasks
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 13, 2023
@ArunSaravananBalachandran @mssonicbld
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
2aabda1 
…tag instead of serial number (sonic-net#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: sonic-net#1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
@mssonicbld mssonicbld mentioned this pull request Dec 13, 2023
Merged
9 tasks
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 13, 2023
@ArunSaravananBalachandran @mssonicbld
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
77a87de 
…tag instead of serial number (sonic-net#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: sonic-net#1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 13, 2023
@ArunSaravananBalachandran @mssonicbld
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
eed53ac 
…tag instead of serial number (sonic-net#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: sonic-net#1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
@mssonicbld mssonicbld mentioned this pull request Dec 13, 2023
Merged
9 tasks
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 13, 2023
@ArunSaravananBalachandran @mssonicbld
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
ca590ed 
…tag instead of serial number (sonic-net#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: sonic-net#1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
@mssonicbld mssonicbld mentioned this pull request Dec 13, 2023
Merged
9 tasks
mssonicbld pushed a commit that referenced this pull request Dec 14, 2023
@ArunSaravananBalachandran @mssonicbld
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
8a76e8f 
…tag instead of serial number (#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: #1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
mssonicbld pushed a commit that referenced this pull request Dec 15, 2023
@ArunSaravananBalachandran @mssonicbld
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
9dbb016 
…tag instead of serial number (#17440)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: #1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.
yxieca pushed a commit that referenced this pull request Dec 18, 2023
@mssonicbld @ArunSaravananBalachandran
[Dell] S6100 - Update EEPROM API serial_number_str to return service …
5a4c51a 
…tag instead of serial number (#17440) (#17493)

To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100.
Ref PR: #1239

How I did it
Update EEPROM API serial_number_str to return service tag instead of serial number.

How to verify it
Verify decode-syseeprom -s returns service tag in Dell S6100.

Co-authored-by: Arun Saravanan Balachandran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @lguohan