[202205][Arista] Fix cmdline generation during warm-reboot from 201811/201911 #12371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1/201911 (sonic-net#11161) Issue fixed: when performing a warm-reboot or fast-reboot from 201811 or 201911 to 202012 the kernel command line contains duplicate information. This issue is related to a change that was made to make 202012 boot0 file more futureproof. A cold reboot brings everything back into a clean slate though not always desirable. Changes done: Added some logic to properly detect the end of the Aboot cmdline when cmdline-aboot-end delimiter is not set (clean case) Added some logic to regenerate the Aboot cmdline when cmdline-aboot-end is set but duplicate parameters exists before (dirty case). Reorganized some code to handle duplicate parameter handling in the allowlist.
Staphylo
force-pushed
the
202205-boot0-fix-old-cmdline
branch
from
32fa9b2 to
9ffabeb
Compare
prgeor
approved these changes
Oct 19, 2022
|
@yxieca could you merge? failure doesn't seem to be related to this pr |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run zure.sonic-buildimage |
|
No pipelines are associated with this pull request. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The cmdline generation has changed between 201911 and 202012 for Arista products.
Doing a fast/warm reboot from 201811 or 201911 to a newer release would lead to cmdline issues.
How I did it
Cherry-picked the fix #11161 that was applied to 202012 onto 202205
How to verify it
Perform a warm-reboot from 201811/201911 to 202205 to validate.
Description for the changelog
Fix cmdline generation during warm-reboot from 201811/201911