[mux] Exit to write standby state to active-active ports
#11821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
5 tasks
lolyu
changed the title
active-active portsstandby state to active-active ports
yxieca
approved these changes
Aug 23, 2022
zjswhhh
approved these changes
Aug 23, 2022
|
Maybe need to do the same thing for bgp service: |
lolyu
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Aug 24, 2022
Approach What is the motivation for this PR? Enable test_heartbeat_failure.py for active-active mux ports. How did you do it? How did you verify/test it? The test cases now fails because of sonic-net/sonic-buildimage#11821
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
aa_mux_exit_standby
branch
from
b19f322 to
d885c66
Compare
|
We should also pass in the module name, in this case 'mux', to the write class, so that it could check if we are warm restarting mux docker. You might want to change the parameter to --shutdown <mux|bgp> so it ready for BGP for the next PR> |
|
Signed-off-by: Longxiang Lyu <[email protected]>
|
Hi, @yxieca, updated, please take a review, thanks! |
yxieca
approved these changes
Aug 31, 2022
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
[mux] Exit to write standby state to `active-active` ports Signed-off-by: Longxiang Lyu <[email protected]>
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 3, 2022
[mux] Exit to write standby state to `active-active` ports Signed-off-by: Longxiang Lyu <[email protected]>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
…t#6211) Approach What is the motivation for this PR? Enable test_heartbeat_failure.py for active-active mux ports. How did you do it? How did you verify/test it? The test cases now fails because of sonic-net/sonic-buildimage#11821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
After stopping the
muxcontainer,show mux statusreturnsactiveforactive-activeports, which should be instandbystate.Signed-off-by: Longxiang Lyu [email protected]
How I did it
Let
muxexit by callingwrite_standby.pywith args to writestandbyforactive-activeports.How to verify it
Stop
muxcontainer and verifyactive-activeports are instandby.Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)