Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[write_standby] update write_standby.py script #11650

Merged
merged 5 commits into from
Aug 9, 2022
Merged

[write_standby] update write_standby.py script #11650

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edc0140
[write_standby] update write_standby.py script
yxieca Aug 8, 2022
2b403ec
update default value
yxieca Aug 8, 2022
e3e7923
set default according to dual-tor type
yxieca Aug 9, 2022
bf309e6
fix issue found in test
yxieca Aug 9, 2022
b61ef78
fine controls
yxieca Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions files/scripts/write_standby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,21 @@ def is_warmrestart(self):

return status and value == 'true'

def get_auto_mux_intfs(self):
def get_all_mux_intfs_modes(self):
"""
Returns a list of all mux cable interfaces that are configured to auto-switch
Returns a list of all mux cable interfaces, with suggested modes
Setting mux initial modes is crucial to kick off the statemachines,
have to set the modes for all mux/gRPC ports.
"""
intf_modes = {}
all_intfs = self.config_db.get_table('MUX_CABLE')
auto_intfs = [intf for intf, status in all_intfs.items()
if status['state'].lower() == 'auto']
return auto_intfs
for intf, status in all_intfs.items():
state = status['state'].lower()
if state == 'standby':
intf_modes[intf] = 'standby'
elif state in ['active', 'auto', 'manual']:
intf_modes[intf] = 'active'
yxieca marked this conversation as resolved.
Show resolved Hide resolved
return intf_modes

def tunnel_exists(self):
"""
Expand Down Expand Up @@ -144,14 +151,13 @@ def apply_mux_config(self):
logger.log_warning("Skip setting mux state due to ongoing warmrestart.")
return

intfs = self.get_auto_mux_intfs()
state = 'standby'
modes = self.get_all_mux_intfs_modes()
if self.wait_for_tunnel():
logger.log_warning("Applying {} state to interfaces {}".format(state, intfs))
logger.log_warning("Applying state to interfaces {}".format(modes))
producer_state_table = ProducerStateTable(self.appl_db, 'MUX_CABLE_TABLE')
fvs = create_fvs(state=state)

for intf in intfs:
for intf, state in modes.items():
fvs = create_fvs(state=state)
producer_state_table.set(intf, fvs)
else:
logger.log_error("Timed out waiting for tunnel {}, mux state will not be written".format(self.tunnel_name))
Expand Down