-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Add arch folder to SDK binary location #11278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Jun 28, 2022
liat-grozovik
approved these changes
Jun 29, 2022
liat-grozovik
changed the title
[mellanox] Add arch folder to SDK binary location
[Mellanox] Add arch folder to SDK binary location
Jun 29, 2022
dgsudharsan
added
Request for 202012 Branch
Request for 202111 Branch
For PRs being requested for 202111 branch
Request for 202205 Branch
labels
Jun 29, 2022
@alexrallen this change cannot be cherry-picked to 202205 branch cleanly, please raise PR if needed. |
@alexrallen can you please also provide guidelines to 202012 and 202111? |
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 5, 2022
- Why I did it This is for the eventual support of multiple architectures for the mellanox platform. - How I did it Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for. This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image. - How to verify it Build SONiC for mellanox and verify it compiles successfully.
yxieca
pushed a commit
that referenced
this pull request
Jul 6, 2022
- Why I did it This is for the eventual support of multiple architectures for the mellanox platform. - How I did it Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for. This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image. - How to verify it Build SONiC for mellanox and verify it compiles successfully.
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 1, 2022
- Why I did it This is for the eventual support of multiple architectures for the mellanox platform. - How I did it Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for. This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image. - How to verify it Build SONiC for mellanox and verify it compiles successfully.
liat-grozovik
pushed a commit
that referenced
this pull request
Aug 11, 2022
…11598) - Why I did it This is for the eventual support of multiple architectures for the mellanox platform. - How I did it Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for. This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image. - How to verify it Build SONiC for mellanox and verify it compiles successfully.
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
- Why I did it This is for the eventual support of multiple architectures for the mellanox platform. - How I did it Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for. This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image. - How to verify it Build SONiC for mellanox and verify it compiles successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cherry Pick Conflict_202205
Included in 202012 Branch
Included in 202205 Branch
Request for 202012 Branch
Request for 202111 Branch
For PRs being requested for 202111 branch
Request for 202205 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.
How I did it
Change the location of the binaries in
Switch-SDK-drivers
so that the path specifies the target architecture in addition to the target distribution that the debians are built for.This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.
How to verify it
Build SONiC for mellanox and verify it compiles successfully.
Which release branch to backport (provide reason below if selected)
Description for the changelog
[mellanox] Add arch folder to SDK binary location
A picture of a cute animal (not mandatory but encouraged)