Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-feature.yang] fix check_up_status field type #10986

Merged
merged 3 commits into from
Jun 19, 2022
Merged

[sonic-feature.yang] fix check_up_status field type #10986

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
364f327
[sonic-feature.yang] fix check_up_status field type
stepanblyschak May 30, 2022
67f05f2
Merge branch 'master' into fix-yang
stepanblyschak Jun 10, 2022
0e97374
Merge branch 'master' into fix-yang
liat-grozovik Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sonic-yang-models/yang-models/sonic-feature.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ module sonic-feature{
leaf check_up_status {
description "This configuration controls the system ready tool to check
the app ready/up status";
type boolean;
default false;
type stypes:boolean_type;
default "false";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiluo-msft Without this fix sonic-utilities submodule update is blocked. There were no UT when this field was added. I suggest to take this fix to unblock submodule update and the owner of new feature adds UT.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wen587 for awareness of blocking issue of sonic-utilities submodule update

}
}
}
Expand Down