[sonic-cfggen]: Update UT to add port lanes #10362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gang Lv [email protected]
Signed-off-by: Gang Lv [email protected]
Signed-off-by: Gang Lv [email protected]
Signed-off-by: Gang Lv [email protected]
Signed-off-by: Gang Lv [email protected]
Signed-off-by: Gang Lv [email protected]
Signed-off-by: Gang Lv [email protected]
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Mar 31, 2022
| <AlternateSpeeds i:nil="true"/> | ||
| <EnableFlowControl>true</EnableFlowControl> | ||
| <Index>1</Index> | ||
| <InterfaceName>Ethernet4</InterfaceName> |
There was a problem hiding this comment.
There's no speed for these ports.
We shouldn't update device/arista/x86_64-arista_7050_qx32s/Arista-7050QX-32S/port_config.ini, so I update this xml.
There was a problem hiding this comment.
If port speed is not mandatory, no need to fix?
There was a problem hiding this comment.
I have removed this change
Do you need to change this line at the same time? In reply to: 1084154358 In reply to: 1084154358 In reply to: 1084154358 Refers to: src/sonic-config-engine/tests/sample_graph.xml:115 in f313124. [](commit_id = f313124, deletion_comment = False) |
qiluo-msft
reviewed
Mar 31, 2022
qiluo-msft
reviewed
Mar 31, 2022
qiluo-msft
reviewed
Mar 31, 2022
qiluo-msft
reviewed
Mar 31, 2022
src/sonic-config-engine/tests/multi_npu_data/sample_port_config.ini
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Mar 31, 2022
ganglyu
requested review from
SuvarnaMeenakshi,
theasianpianist,
smaheshm and
dgsudharsan
ganglyu
changed the title
qiluo-msft
reviewed
Apr 1, 2022
qiluo-msft
reviewed
Apr 2, 2022
| output = self.run_script(argument) | ||
|
|
||
| #self.maxDiff = None |
Signed-off-by: Gang Lv [email protected]
qiluo-msft
reviewed
Apr 3, 2022
| @@ -877,6 +879,7 @@ def test_minigraph_voq_inband_port(self): | |||
| self.assertDictEqual( | |||
| output_dict['Ethernet-IB0'], | |||
| {'lanes': '133', | |||
|
|
|||
| 'alias': 'Recycle0', | |||
There was a problem hiding this comment.
Could you remove the unnecessary new line? #Closed
qiluo-msft
reviewed
Apr 3, 2022
| output = json.loads(self.run_script(argument)) | ||
| self.assertDictEqual(output, | ||
| {"Ethernet0": { "admin_status": "up", "alias": "Ethernet1/1", "asic_port_name": "Eth0-ASIC0", "description": "01T2:Ethernet1:config_db", "index": "0", "lanes": "33,34,35,36", "mtu": "9100", "tpid": "0x8100", "pfc_asym": "off", "role": "Ext", "speed": "40000", "autoneg": "on" }, | ||
| "Ethernet4": { "admin_status": "up", "alias": "Ethernet1/2", "asic_port_name": "Eth1-ASIC0", "description": "01T2:Ethernet2:config_db", "index": "1", "lanes": "29,30,31,32", "mtu": "9100", "tpid": "0x8100", "pfc_asym": "off", "role": "Ext", "speed": "40000", "autoneg": "on" }, | ||
| "Ethernet8": { "admin_status": "up", "alias": "Ethernet1/3", "asic_port_name": "Eth2-ASIC0", "description": "Ethernet1/3:config_db", "index": "2", "lanes": "41,42,43,44", "mtu": "9100", "tpid": "0x8100", "pfc_asym": "off", "role": "Ext", "speed": "40000" }, |
There was a problem hiding this comment.
Why admin_status disappear? Is it expected? #Closed
There was a problem hiding this comment.
The actual output does not have admin_status
qiluo-msft
approved these changes
Apr 3, 2022
6 tasks
ganglyu
added
the
Request for 202111 Branch
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
as it was before PR sonic-net#10362. Signed-off-by: Suvarna Meenakshi <[email protected]>
6 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Apr 18, 2022
Why I did it Need to run yang validation for sonic-cfggen unit test, and many unit test does not provide lanes for port table. How I did it Update port config file. How to verify it Run sonic-cfggen unit test, Use below PR to verify #10228 Signed-off-by: Gang Lv [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Lv [email protected]
Why I did it
Need to run yang validation for sonic-cfggen unit test, and many unit test does not provide lanes for port table.
How I did it
Update port config file.
How to verify it
Run sonic-cfggen unit test,
Use below PR to verify
#10228
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix #9553
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)