-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YANG] Add support for Password Hardening #10322
Merged
liat-grozovik
merged 19 commits into
sonic-net:master
from
davidpil2002:dev-password-hardening-yang-model
May 29, 2022
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d6e62e8
add password hardening yang model, yang test, init_cfg.json.j2 files
davidpil2002 f844b43
fix comments from P.R: add 3 YANG test, add YANG sample
davidpil2002 0d143f1
Merge branch 'master' into dev-password-hardening-yang-model
davidpil2002 a8cfb45
Add Password Hardening documentation to the YANG Configuration.md file
davidpil2002 7f6b284
remove white spaces
davidpil2002 b0a6f5c
fix Yang model test, replace PASSWORD table name to PASSW_HARDENING
davidpil2002 7b42206
fix yang test config typo true instead True
davidpil2002 9a68dd1
Password Hardening Yang model, fix typo
davidpil2002 90ed1ad
Passw Hardening Fix Yang test PASSWORD_BAD_EXPIRATION
davidpil2002 a978ef1
Passw Hardening fix Yang test expiration warning & len-min cases
davidpil2002 5e17f03
Passw Hardening - fix Table name PASSWORD
davidpil2002 6d222f7
add sonic-passwh.yang to setup.py file
davidpil2002 69190ef
Passw hardening, fix typo in sample_config_db.json
davidpil2002 b2404e1
Password Hardening Yang test - fix typo in sample_config_db.json file
davidpil2002 668d7ea
Password Hardening Yang test - fix typo in init_cfg.json.j2 file
davidpil2002 72f4446
Merge branch 'master' into dev-password-hardening-yang-model
davidpil2002 3ad5476
fix revision date in sonic-passwh.yang file
davidpil2002 4d3cf3b
Merge branch 'master' into dev-password-hardening-yang-model
davidpil2002 a6f7227
[password-hardening]Add state feature disabled as default in yang model
davidpil2002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
src/sonic-yang-models/tests/yang_model_tests/tests/password_hardening.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
{ | ||
"PASSWORD_TABLE": { | ||
"desc": "Configure policer with all default fields." | ||
}, | ||
"PASSWORD_ENABLE_FEATURE_WITH_POLICIES": { | ||
"desc": "Configure password policies and enabled feature." | ||
}, | ||
"PASSWORD_BAD_ENABLE_FEATURE": { | ||
"desc": "Configure password policies enabled feature with a wrong value.", | ||
"eStrKey" : "InvalidValue" | ||
}, | ||
"PASSWORD_BAD_DIGIT": { | ||
"desc": "Configure password Digit Class policy with invalid value", | ||
"eStrKey" : "InvalidValue" | ||
}, | ||
"PASSWORD_BAD_HISTORY_CNT": { | ||
"desc": "Configure password history_cnt with out of range value", | ||
"eStrKey" : "InvalidValue" | ||
}, | ||
"PASSWORD_BAD_LEN_MIN": { | ||
"desc": "Configure password len-min with out of range value", | ||
"eStrKey" : "Pattern" | ||
}, | ||
"PASSWORD_BAD_EXPIRATION": { | ||
"desc": "Configure password expiration with out of range value", | ||
"eStrKey" : "Pattern" | ||
}, | ||
"PASSWORD_BAD_EXPIRATION_WARN": { | ||
"desc": "Configure password expiration-warning with out of range value", | ||
"eStrKey" : "Pattern" | ||
} | ||
} |
146 changes: 146 additions & 0 deletions
146
src/sonic-yang-models/tests/yang_model_tests/tests_config/password_hardening.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,146 @@ | ||
{ | ||
"PASSWORD_TABLE": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "disabled", | ||
"expiration": "180", | ||
"expiration_warning": "15", | ||
"history_cnt": "10", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_ENABLE_FEATURE_WITH_POLICIES": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "enabled", | ||
"expiration": "180", | ||
"expiration_warning": "15", | ||
"history_cnt": "10", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_BAD_ENABLE_FEATURE": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "33", | ||
"expiration": "180", | ||
"expiration_warning": "15", | ||
"history_cnt": "10", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_BAD_DIGIT": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "disabled", | ||
"expiration": "180", | ||
"expiration_warning": "15", | ||
"history_cnt": "10", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": "1", | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_BAD_HISTORY_CNT": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "enabled", | ||
"expiration": "180", | ||
"expiration_warning": "15", | ||
"history_cnt": "300", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_BAD_LEN_MIN": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "enabled", | ||
"expiration": "180", | ||
"expiration_warning": "15", | ||
"history_cnt": "50", | ||
"len_min": "50", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_BAD_EXPIRATION": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "enabled", | ||
"expiration": "400", | ||
"expiration_warning": "15", | ||
"history_cnt": "50", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
}, | ||
"PASSWORD_BAD_EXPIRATION_WARN": { | ||
"sonic-passwh:sonic-passwh": { | ||
"sonic-passwh:PASSW_HARDENING": { | ||
"POLICIES":{ | ||
"state": "enabled", | ||
"expiration": "180", | ||
"expiration_warning": "40", | ||
"history_cnt": "10", | ||
"len_min": "8", | ||
"reject_user_passw_match": true, | ||
"lower_class": true, | ||
"upper_class": true, | ||
"digits_class": true, | ||
"special_class": true | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
module sonic-passwh { | ||
yang-version 1.1; | ||
namespace "https://github.com/Azure/sonic-passwh"; | ||
prefix password; | ||
|
||
description "PASSWORD HARDENING YANG Module for SONiC OS"; | ||
|
||
revision 2022-05-03 { | ||
description "First Revision"; | ||
} | ||
|
||
container sonic-passwh { | ||
|
||
typedef feature_state { | ||
type enumeration { | ||
enum enabled; | ||
enum disabled; | ||
} | ||
} | ||
|
||
container PASSW_HARDENING { | ||
description "PASSWORD HARDENING part of config_db.json"; | ||
container POLICIES { | ||
leaf state { | ||
description "state of the feature"; | ||
type feature_state; | ||
default "disabled"; | ||
} | ||
leaf expiration { | ||
description "expiration time (days unit)"; | ||
type uint16 { | ||
range 1..365; | ||
} | ||
} | ||
leaf expiration_warning { | ||
description "expiration warning time (days unit)"; | ||
type uint8 { | ||
range 1..30; | ||
} | ||
} | ||
leaf history_cnt { | ||
description "num of old password that the system will recorded"; | ||
type uint8 { | ||
range 1..100; | ||
} | ||
} | ||
leaf len_min { | ||
description "password min length"; | ||
type uint8 { | ||
range 1..32; | ||
} | ||
} | ||
leaf reject_user_passw_match{ | ||
description "username password match"; | ||
type boolean; | ||
} | ||
leaf lower_class{ | ||
description "password lower chars policy"; | ||
type boolean; | ||
} | ||
leaf upper_class{ | ||
description "password upper chars policy"; | ||
type boolean; | ||
} | ||
leaf digits_class{ | ||
description "password digits chars policy"; | ||
type boolean; | ||
} | ||
leaf special_class{ | ||
description "password special chars policy"; | ||
type boolean; | ||
} | ||
}/*container policies */ | ||
} /* container PASSWH */ | ||
}/* container sonic-passwh */ | ||
}/* end of module sonic-passwh */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature will set to disable by default, so maybe add default values to yang model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgsudharsan I removed the default because I understand from you that it is not necessary anymore,
can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuh-80 In the yang subgroup meeting it is decided not to have default in yang model but rather handle it in application. The reason is having default will push it to config_db and currently there is no way to differentiate between user configuration from default configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have the same concern. We should add default value (disable) into yang model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done