Skip to content

Commit

Permalink
[sonic-config-engine] Pin 'importlib-resources' package to v3.3.1 for…
Browse files Browse the repository at this point in the history
… Python 2 (#6288)

importlib-resources v4.0.0 was released today (2020-12-23) and drops support for Python 2. This caused the sonic-config-engine Python 2 wheel build to fail.

Reference: https://pypi.org/project/importlib-resources/

Pin 'importlib-resources' package to v3.3.1 for Python 2
Unrelated: remove pinned version of zipp for sonic-bgpcfgd because we no longer build a Python 2 version of that package
  • Loading branch information
jleveque authored Dec 24, 2020
1 parent df13245 commit e39cc01
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/sonic-bgpcfgd/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
'jinja2>=2.10',
'netaddr==0.8.0',
'pyyaml==5.3.1',
'zipp==1.2.0', # importlib-resources needs zipp and seems to have a bug where it will try to import too new of a version for Python 2
],
setup_requires = [
'pytest-runner',
Expand Down
3 changes: 2 additions & 1 deletion src/sonic-config-engine/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
'future',
'Jinja2<3.0.0',
'pyangbind==0.6.0',
'zipp==1.2.0', # importlib-resources needs zipp and seems to have a bug where it will try to install too new of a version for Python 2
'zipp==1.2.0', # importlib-resources needs zipp and seems to have a bug where it will try to install too new of a version for Python 2
'importlib-resources==3.3.1' # importlib-resources v4.0.0 was released 2020-12-23 and drops support for Python 2
]


Expand Down

0 comments on commit e39cc01

Please sign in to comment.