Fix build

Signed-off-by: maipbui <[email protected]>
sonic-net · Oct 5, 2022 · 1e62cff · 1e62cff
1 parent ba3c5de
commit 1e62cff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/platform/mellanox/mlnx-platform-api/sonic_platform/fan.py b/platform/mellanox/mlnx-platform-api/sonic_platform/fan.py
@@ -218,8 +218,8 @@ def set_speed(self, speed):
             addr = utils.read_str_from_file(self.psu_i2c_addr_path, raise_exception=True)
             command = utils.read_str_from_file(self.psu_i2c_command_path, raise_exception=True)
             speed = self.PSU_FAN_SPEED[int(speed // 10)]
-            command = "i2cset -f -y {0} {1} {2} {3} wp".format(bus, addr, command, speed)
-            subprocess.check_call(command, shell = True, universal_newlines=True)
+            command = ["i2cset", "-f", "-y", bus, addr, command, speed, "wp"]
+            subprocess.check_call(command, universal_newlines=True)
             return True
         except subprocess.CalledProcessError as ce:
             logger.log_error('Failed to call command {}, return code={}, command output={}'.format(ce.cmd, ce.returncode, ce.output))

diff --git a/platform/mellanox/mlnx-platform-api/tests/test_chassis.py b/platform/mellanox/mlnx-platform-api/tests/test_chassis.py
@@ -276,7 +276,7 @@ def test_revision_permission(self):
         #Override the dmi file
         sonic_platform.chassis.DMI_FILE = "/tmp/dmi_file"
         new_dmi_file = sonic_platform.chassis.DMI_FILE
-        subprocess.run(["touch ", new_dmi_file])
+        subprocess.run(["touch", new_dmi_file])
         subprocess.run(["chmod", "-r", new_dmi_file])
         chassis = Chassis()
         rev = chassis.get_revision()