Copp manager redesign test plan #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
|
@dgsudharsan and @prsunny could you please approve this change? |
prsunny
reviewed
Jan 24, 2022
|
|
||
|
|
||
|
|
||
| ### Test cases #5 - Verify trap configuration is saved or not after reboot(reboot, fast-reboot, warm-reboot) |
There was a problem hiding this comment.
I think, one more case to verify is the sflow example where the entry is present in copp.json, but not in feature table. It should not be installed until the feature is enabled. Basically, Test 3, by reversing step 1 and 2 may be for a different trap
There was a problem hiding this comment.
@prsunny I believe Test case 4 should cover the scenario and our copp swss UT handles it. The reason we cannot test sflow in sonic mgmt is if we disable the feature, sampling itself will be disabled and so we cannot assume that packets are not lifted because of trap removal or sampling itself is disabled. That's why we use BGP to test this usecase.
There was a problem hiding this comment.
I meant sflow as an example. Just want to make sure the sequence is covered. But as you mentioned, Test 4 seems to cover
liat-grozovik
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 26, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
prsunny
previously approved these changes
Jan 27, 2022
JibinBao
force-pushed
the
copp_manager_redesign
branch
from
a92d6ab to
3745827
Compare
dgsudharsan
reviewed
Jan 27, 2022
|
|
||
| ## Overview | ||
|
|
||
| In the current design of Copp Manager, before installing a trap, CoppMgr checks if one of the following requirements is fulfilled: |
There was a problem hiding this comment.
Can we modify 'current design' to 'previous design'?
judyjoseph
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 31, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
Change current desgin to previous desgin
|
@prsunny , @dgsudharsan can you signoff? |
prsunny
approved these changes
Feb 15, 2022
dgsudharsan
approved these changes
Feb 15, 2022
|
@JibinBao once the PR is ready please add it to the PR description for reference. |
noaOrMlnx
added a commit
to noaOrMlnx/sonic-swss
that referenced
this pull request
Feb 16, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test plan for CoPP Manager redesign feature