core/txpool/legacypool: legacypool supports SetCode tx #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonhv0212
force-pushed
the
eip-7702-tx-pool
branch
from
414f06e to
30f2d2f
Compare
minh-bq
reviewed
Mar 11, 2025
| // Authorities cannot conflict with any pending or queued transactions. | ||
| if auths := tx.SetCodeAuthorities(); len(auths) > 0 { | ||
| for _, auth := range auths { | ||
| if pool.pending[auth] != nil || pool.queue[auth] != nil { |
There was a problem hiding this comment.
I think we should add || pool.totalPendingPayerCost[auth] != nil to avoid conflict with pending payer in sponsored transaction
| // restrictions brought by SetCode transaction type. | ||
| func (pool *LegacyPool) validateAuth(tx *types.Transaction) error { | ||
| from, _ := types.Sender(pool.signer, tx) // validated | ||
|
|
There was a problem hiding this comment.
We should add this to reject sponsored transaction with pending authorization
payer, err := types.Payer(pool.signer, tx)
if err == nil {
if pool.currentState.GetCodeHash(payer) != emptyCodeHash || len(pool.all.auths[payer]) != 0 {
return ErrInflightTxLimitReached
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs
Description
In this PR:
UsedAndLeftSlotsbecomes an optional callback inValidationOptionsWithState.lookupto track pooled authorization