Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 余额不足提示中文增强引导性 #1481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jinjianming
Copy link
Contributor

close #issue_number

我已确认该 PR 已自测通过,相关截图如下:
image
image

(此处放上测试通过的截图,如果不涉及前端改动或从 UI 上无法看出,请放终端启动成功的截图)

@jinjianming jinjianming changed the title 余额不足提示中文增强 余额不足提示中文增强引导性 May 29, 2024
@Laisky
Copy link
Collaborator

Laisky commented Jun 27, 2024

message 可以中文,但是 code 应该保留英文。这个 code 的设计,我理解是为 i18n 提供标准化的依据。

@jinjianming
Copy link
Contributor Author

message可以中文,但是code应该保留英文。这个代码的设计,我理解是为i18n提供标准化的依据。

已将code改为insufficient_user_quota

@Laisky
Copy link
Collaborator

Laisky commented Jun 27, 2024

可以考虑把提交合并一下,还有 CI 也挂了两个,可以看一下。

@jinjianming jinjianming force-pushed the Insufficient branch 3 times, most recently from 29a2124 to ca30117 Compare June 27, 2024 05:35
@jinjianming
Copy link
Contributor Author

GraphQL: Resource not accessible by integration (addComment) @Laisky 貌似没有权限?

@jinjianming jinjianming changed the title 余额不足提示中文增强引导性 feat: 余额不足提示中文增强引导性 Jun 27, 2024
@Laisky
Copy link
Collaborator

Laisky commented Jun 27, 2024

@songquanpeng Code coverage report 的 CI 看上去因为 github token 的问题,都挂了

@songquanpeng
Copy link
Owner

@songquanpeng Code coverage report 的 CI 看上去因为 github token 的问题,都挂了

不好意思现在才看到,这个已经修复了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants