Fix build error when building ray for python first and then building … #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ray for java
What do these changes do?
Now, Ray supports not only Python client but also Java client, we can build Ray for both. However, if we build ray for Python first and then build ray for Java, we'll fail. That's because Ray's build depends on Arrow which only be built once. Arrow will not generate libs for Java when building Ray for Python (BTW, if we build Ray for Java first, we will also generate arrow's Python client).
So, to solve the problem, we should make sure Arrow will be built again when building Ray for Java later while Ray's build is as before when building Ray for Java first.