fix: replace string.Equals with ToUpper comparison in SwitchesController#94
Merged
sondresjolyst merged 1 commit intodevelopmentfrom Apr 16, 2026
Merged
Conversation
sondresjolyst
added a commit
that referenced
this pull request
Apr 16, 2026
…ler (#94) (#95) * fix(switches): whitelist SOCKET type in GET /api/switches Only return switches with type 'SOCKET'. This excludes SHRGBC light bulbs and any other unknown device types, keeping the list to actionable socket devices only. * fix: replace string.Equals with ToUpper comparison in SwitchesController (#94)
sondresjolyst
added a commit
that referenced
this pull request
Apr 18, 2026
* fix: replace string.Equals with ToUpper comparison in SwitchesController (#94) (#95) * fix(switches): whitelist SOCKET type in GET /api/switches Only return switches with type 'SOCKET'. This excludes SHRGBC light bulbs and any other unknown device types, keeping the list to actionable socket devices only. * fix: replace string.Equals with ToUpper comparison in SwitchesController (#94) * chore(main): release 1.7.2 (#96) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat!: rename roles --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GetAllSwitches was crashing with a 500 error because EF Core cannot translate string.Equals with StringComparison to SQL.
Fix
Replaced .Equals with .ToUpper() == "SOCKET" which EF Core can translate to valid SQL.