Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete build directives #117

Merged
merged 1 commit into from
Sep 19, 2024
Merged

remove obsolete build directives #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package db

Expand Down
4 changes: 2 additions & 2 deletions db/db_mocks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package db

Expand All @@ -30,7 +29,8 @@ import (
)

// SetupMockDB should always be followed by a call to the closeDbFunc, like so:
// mock, db, closeDbFunc := SetupMockDB(t)
//
// mock, db, closeDbFunc := SetupMockDB(t)
// defer closeDbFunc()
func SetupMockDB(t *testing.T) (mock sqlmock.Sqlmock, mockDbIf *ClaDB, closeDbFunc func()) {
db, mock, err := sqlmock.New()
Expand Down
1 change: 0 additions & 1 deletion db/db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package db

Expand Down
1 change: 0 additions & 1 deletion github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package github

Expand Down
1 change: 0 additions & 1 deletion github/github_mocks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package github

Expand Down
1 change: 0 additions & 1 deletion github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package github

Expand Down
1 change: 0 additions & 1 deletion oauth/oauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package oauth

Expand Down
1 change: 0 additions & 1 deletion oauth/oauth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package oauth

Expand Down
6 changes: 0 additions & 6 deletions server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package main

Expand Down Expand Up @@ -529,18 +528,13 @@ func notifySignatureComplete(signature *types.UserSignature) (err error) {
auth := smtp.PlainAuth("", smtpUsername, smtpPassword, smtpHost)
to := []string{notificationAddress}
msg := []byte("To: " + notificationAddress + "\r\n" +

"Subject: CLA Signature Received\r\n" +

"\r\n" +

"CLA Version " + signature.CLAVersion + " has been signed at " + signature.TimeSigned.Format(time.RFC1123Z) + ".\r\n\r\n" +

"Details are: \r\n" +
" GitHub User ID: " + signature.User.Login + "\r\n" +
" Given Name : " + signature.User.GivenName + "\r\n" +
" Email Address : " + signature.User.Email + "\r\n\r\n" +

"CLA Text below was as signed (obtained from " + signature.CLATextUrl + "):\r\n\r\n" + signature.CLAText)

if smtpHost == "" || smtpPort == "" || notificationAddress == "" {
Expand Down
1 change: 0 additions & 1 deletion server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package main

Expand Down
1 change: 0 additions & 1 deletion types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
//

//go:build go1.16
// +build go1.16

package types

Expand Down