#80 Allows to set directories to include and exclude #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermo-varela
force-pushed
the
#80_reduce_noise_android_iq_reports
branch
from
41bde7a to
3624296
Compare
shaikhu
reviewed
Aug 5, 2021
shaikhu
reviewed
Aug 5, 2021
shaikhu
reviewed
Aug 5, 2021
| @@ -131,6 +131,15 @@ public void scan() { | |||
| } | |||
| } | |||
|
|
|||
| private Properties buildProperties() { | |||
| Properties properties = new Properties(); | |||
| if (!StringUtils.isAllBlank(extension.getDirIncludes(), extension.getDirExcludes())) { | |||
There was a problem hiding this comment.
Question. This expects a user must enter both the dirIncludes and dirExcludes. They can't just enter one. Is that the intended behaviour?
There was a problem hiding this comment.
Question. This expects a user must enter both the
dirIncludesanddirExcludes. They can't just enter one. Is that the intended behaviour?
Good catch!
1885f59
shaikhu
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to set directories to include and exclude in Nexus IQ.
Evaluation reports will have less noise when setting
dirExcludes = '**/classes.jar,**/annotations.zip,**/lint.jar,**/internal_impl-*.jar'by excluding those files that are marked as unknown:It relates to the following issue #s:
cc @bhamail / @DarthHater / @guillermo-varela / @shaikhu