CLM-18313 Builds the artifact ID for InnerSource dependency manually #73
Conversation
| ModuleVersionIdentifier artifactId = resolvedArtifact.getModuleVersion().getId(); | ||
|
|
||
| Artifact artifact = new Artifact() | ||
| .setId(artifactId.getGroup() + ":" + artifactId.getName() + ":" + artifactId.getVersion()) | ||
| .setPathname(resolvedArtifact.getFile()) | ||
| .setMonitored(true); | ||
|
|
There was a problem hiding this comment.
Should there be a unit test to test this part? that the artifact has the expected outcome?
There was a problem hiding this comment.
Should there be a unit test to test this part? that the artifact has the expected outcome?
There are already tests checking the output is group:name (artifactId):version
For instance:
https://github.com/sonatype-nexus-community/scan-gradle-plugin/blob/master/src/test/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinderTest.java#L177
The case the customer presents couldn't be reproduced (getting extra info in version for SNAPSHOT components) using the current approach, but concatenating those fields manually proved to provide a proper result as per the output they provided in the latest reply by mail.
| ModuleVersionIdentifier artifactId = resolvedArtifact.getModuleVersion().getId(); | ||
|
|
||
| Artifact artifact = new Artifact() | ||
| .setId(artifactId.getGroup() + ":" + artifactId.getName() + ":" + artifactId.getVersion()) |
There was a problem hiding this comment.
Does the ModuleVersionIdentifier has any info on classifier and extension ?
There was a problem hiding this comment.
Does the
ModuleVersionIdentifierhas any info onclassifierandextension?
Nope!
Only group, name and version: https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/ModuleVersionIdentifier.html
A Nexus IQ customer is having troubles having InnerSource working properly. After analyzing the files shared by the customer we see the "artifact ID" has a colon (:) in the version fragment for SNAPSHOT dependencies.
By manually building this ID the idea is to avoid any extra characters that a might be introduce in the display name of a component identifier by Gradle.
cc @bhamail / @DarthHater / @guillermo-varela / @shaikhu