Added Jreleaser #174
Added Jreleaser #174
Conversation
paul-botsco-2-0
bot
added
the
😧 commits missing verification
|
Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set. The commits to review are:
See Signed Commits. |
|
Thanks for the contribution. Before we can merge this, we need @mburkert3, @mburkert3 to sign the Contributor License Agreement |
paul-botsco-2-0
bot
added
😍 cla signed
|
Question. JReleaser is for releasing to central right? The existing logic handles publishing to the gradle plugin portal? |
build.gradle
Outdated
| // Configure signing | ||
| signing { | ||
| useInMemoryPgpKeys(System.getenv('GPG_SIGNING_KEY'), System.getenv('GPG_PASSPHRASE')) | ||
| sign publishing.publications.maven | ||
|
|
||
| } |
There was a problem hiding this comment.
Would this attempt to sign the compiled binary in local development as well?
build.gradle
Outdated
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Configure signing | ||
| signing { | ||
| useInMemoryPgpKeys(System.getenv('GPG_SIGNING_KEY'), System.getenv('GPG_PASSPHRASE')) |
There was a problem hiding this comment.
Will this handle decoding the base64 encoded PGP signing key?
There was a problem hiding this comment.
I believe the useInMemoryPGPKeys should handle that
|
Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set. The commits to review are:
See Signed Commits. |
|
Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set. The commits to review are:
See Signed Commits. |
| if (System.getenv('RELEASE_BUILD') == 'true') { | ||
| signing { | ||
| def final encodedKey = System.getenv('GPG_SIGNING_KEY') | ||
| def final signingKey = new String(encodedKey.decodeBase64()) |
Added JReleaser so we can publish directly to maven central
It relates to the following issue #s:
BNR-1226
cc @bhamail / @DarthHater / @guillermo-varela / @shaikhu