Fix commit hash discovery #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi!
First of all, thank you for opening your first pull-request. Elementary, we appreciate all submissions that helps us continue improving this plugin.
Please take a look to our contributing guidelines and make sure all requirements are fulfilled.
As this is a community project we can't commit to official due dates for reviews and developing, but we're definitely committed to delivering services, integrations and plugins of top quality.
So please be patient, we will review your pull-request and get back to you as soon as we can!
Regards,
Sherlock Trunks 🐘
|
Tested locally with sample gradle project and was able to discover commit hash 🎉 |
src/main/java/org/sonatype/gradle/plugins/scan/nexus/iq/scan/NexusIqPluginScanExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sonatype/gradle/plugins/scan/nexus/iq/scan/NexusIqPluginScanExtension.java
Show resolved
Hide resolved
|
Thanks for your contribution @eduard-tita 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
scanFolderPathfield inNexusIqPluginScanExtension(the current value will never work).scanFolderPathfield in order to properly collect the commit hash during scans.It relates to the following issue #s:
cc @bhamail / @DarthHater / @guillermo-varela / @shaikhu