Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for success metrics in web view #112

Merged

Conversation

rpanman-sonatype
Copy link
Collaborator

Before this PR it was mandatory to have a successmetrics.csv file to view any metrics in web view. This PR removes that limitation.

@rpanman-sonatype rpanman-sonatype force-pushed the allow_view_metrics_without_success_metrics branch from 965098d to eb26e7a Compare February 11, 2023 11:53
@sonatype-lift
Copy link

sonatype-lift bot commented Feb 11, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/sonatype-nexus-community/nexusiq-successmetrics/112.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/sonatype-nexus-community/nexusiq-successmetrics/112.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@rpanman-sonatype rpanman-sonatype force-pushed the allow_view_metrics_without_success_metrics branch from eb26e7a to 12e6a18 Compare February 11, 2023 12:05
@rpanman-sonatype rpanman-sonatype force-pushed the allow_view_metrics_without_success_metrics branch from 12e6a18 to 1bbf1e3 Compare February 11, 2023 12:14
@rpanman-sonatype rpanman-sonatype merged commit 4f787ab into develop Feb 11, 2023
@rpanman-sonatype rpanman-sonatype deleted the allow_view_metrics_without_success_metrics branch February 11, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant