(feat) Add in the ability to pass in -D or --directory if you want to… #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run auditjs on another directory than cwd, default = cwd like normal. Good for global directory
…he node_modules, it trims that
timlevett
commented
Mar 19, 2020
| @@ -1,3 +1,4 @@ | |||
| { | |||
| "editor.formatOnSave": true | |||
| } | |||
| "editor.formatOnSave": false, | |||
There was a problem hiding this comment.
I had to disable this because it was breaking the build on a space it was adding between the {} on https://github.com/sonatype-nexus-community/auditjs/pull/186/files#diff-e2206ba0c17727f95c268ab7b1f899e3R22
There was a problem hiding this comment.
Shrug. I'm still using IDEA. ;)
There was a problem hiding this comment.
^^^ noooooob.
Just kidding :)
I'll try and pull this down and take a gander at why it was breaking the build.
DarthHater
reviewed
Mar 19, 2020
bhamail
approved these changes
Mar 24, 2020
| let directory = argv.directory ? argv.directory : process.cwd(); | ||
|
|
||
| if (directory && directory !== process.cwd()) { | ||
| console.log('Running on directory', directory); |
There was a problem hiding this comment.
SUGGESTION: Rather than use console.log, use: logMessage('', DEBUG); at whatever level you'd like to write it to the log.
| @@ -1,3 +1,4 @@ | |||
| { | |||
| "editor.formatOnSave": true | |||
| } | |||
| "editor.formatOnSave": false, | |||
There was a problem hiding this comment.
Shrug. I'm still using IDEA. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… run auditjs on another directory than cwd, default = cwd like normal. Good for global directory
Add in flag
-Dor--directoryfor ossi or iq so you can scan a directory that is not cwd. Handy for global directory scans.This pull request makes the following changes:
It relates to the following issue #s:
cc @bhamail / @DarthHater / @allenhsieh / @ken-duck