-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Symfony 4.4 compatibility #434
Conversation
As a proof, sonata-project/SonataDoctrineORMAdminBundle#1680 build of Symfony 4.4 is working |
We'll need to do a PR like sonata-project/exporter#605 with a conflict later. |
Why dont we do the conflict thing here too? |
Because we released a not working 2.0.0 version which can be installed with Sf 4.4 There is no way to prevent user to install 2.0.0 since it's released :( |
We can remove the tag, or is it not possible? |
I'm note sure it will be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is simpler this way, lets do it like this. Later we can depend on 2.1 right?
Subject
This config doesn't work for Sf4.4 and we don't have conflict so far.
Changelog