Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Symfony 4.4 compatibility #434

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

VincentLanglet
Copy link
Member

Subject

This config doesn't work for Sf4.4 and we don't have conflict so far.

Changelog

### Fixed
- Symfony 4.4 compatibility

@VincentLanglet
Copy link
Member Author

As a proof, sonata-project/SonataDoctrineORMAdminBundle#1680 build of Symfony 4.4 is working

@VincentLanglet VincentLanglet requested review from jordisala1991 and a team August 2, 2022 14:54
@VincentLanglet
Copy link
Member Author

We'll need to do a PR like sonata-project/exporter#605 with a conflict later.

@jordisala1991
Copy link
Member

Why dont we do the conflict thing here too?

@VincentLanglet
Copy link
Member Author

Why dont we do the conflict thing here too?

Because we released a not working 2.0.0 version which can be installed with Sf 4.4
So I need to release a fix 2.0.1
And then we can do the conflict thing.

There is no way to prevent user to install 2.0.0 since it's released :(

@jordisala1991
Copy link
Member

We can remove the tag, or is it not possible?

@VincentLanglet
Copy link
Member Author

VincentLanglet commented Aug 2, 2022

We can remove the tag, or is it not possible?

I'm note sure it will be enough.
I'm not an expert at all ; I just heard it's really hard to completely delete a release.
But we can ask for help about it if you prefer this way.
It seems simpler this way

Copy link
Member

@jordisala1991 jordisala1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is simpler this way, lets do it like this. Later we can depend on 2.1 right?

@VincentLanglet VincentLanglet merged commit 1efdf01 into 2.x Aug 2, 2022
@VincentLanglet VincentLanglet deleted the fixSymfony4Compatibility branch August 2, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants