Detect extension if no one is provided

[jordisala1991]

Subject

I am targeting this branch, because this is BC.

Closes #2208 .

Changelog

### Fixed
- Fixed auto detect extension if the file does not provide it, for example when dealing with temporal filenames.

[jordisala1991]

I faced the same problemas @sarim.

Does this PR fixes your problem also?

[jordisala1991]

This is my code to upload media:

        $tmp = $this->filesystem->tempnam($this->tmp, 'tmp');

        $this->filesystem->dumpFile($tmp, base64_decode($binaryContent));

        $media = new Media();
        $media->setBinaryContent($tmp);
        $media->setContext('default');
        $media->setProviderName('sonata.media.provider.image');
        $media_sizes = getimagesize($tmp);
        $media->setWidth($media_sizes[0]);
        $media->setHeight($media_sizes[1]);

This is my hack around this issue:

        $tmp = $this->filesystem->tempnam($this->tmp, 'tmp');

        $this->filesystem->dumpFile($tmp, base64_decode($binaryContent));

        $imageSize = getimagesize($tmp);
        $extension = MimeTypes::getDefault()->getExtensions($imageSize['mime'])[0] ?? null;

        if (null !== $extension) {
            $this->filesystem->rename($tmp, $tmp . '.' . $extension);

            $tmp .= '.' . $extension;
        }

        $media = new Media();
        $media->setBinaryContent($tmp);
        $media->setContext('default');
        $media->setProviderName('sonata.media.provider.image');
        $media->setWidth($imageSize[0]);
        $media->setHeight($imageSize[1]);

It was working on previous SonataMediaBundle versions, and it works with this fix.

[sarim]

Yeah my code was also working on previous versions, then I upgraded the project and had to apply to following workaround make it work in current sonata media. I won't go into details now, I think I tried my best to explain it in previous two threads, kinda felt like I was not being heard.

Here in this workaround saving the file under its original name makes it have an extension.

             $upload = $request->files->get('files')[0];

+            $file = $upload->move(\sys_get_temp_dir(), \uniqid().$upload->getClientOriginalName());
+
             $media = new Media();
-            $media->setBinaryContent($upload->getPathname());
-            $media->setName($upload->getClientOriginalName());
-            $mediaManager->save($media, $context, 'sonata.media.provider.image');
+            $media->setBinaryContent($file->getPathname());
+            $media->setName($file->getFilename());
+            $media->setContext($context);
+            $media->setProviderName('sonata.media.provider.image');
+            $mediaManager->save($media);

[jordisala1991]

I will need to do a manual release for this one (and a merge to 4.x also) @VincentLanglet, but I would like it to land on 3.x first.

[VincentLanglet]

Is a test possible ?

[jordisala1991]

Is a test possible ?

Yes! done

[VincentLanglet]

@jordisala1991 The 3.x branch is not available anymore on https://master-7rqtwti-ptm4dx6rjpjko.eu-5.platformsh.site/next-releases so the changelog need to be written manually.

Will try to find time tomorrow

[jordisala1991]

No worries, I am on it right now