Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "jms/serializer-bundle" 4.x #2177

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Oct 18, 2021

Subject

Add support for "jms/serializer-bundle" 4.x.

I am targeting this branch, because this change respects BC.

Changelog

### Added
- Support for "jms/serializer-bundle" 4.x.

To do

@jordisala1991
Copy link
Member

Not sure we need to give this support. The jms serializer is removed on 4.x and the feature that uses this library is deprecated already.

@phansys
Copy link
Member Author

phansys commented Oct 20, 2021

Not sure we need to give this support. The jms serializer is removed on 4.x and the feature that uses this library is deprecated already.

The motivation for this change is not the feature provided in this package, but the blocker this dependency generates for 3rd party projects:

composer why-not jms/serializer-bundle ^4
sonata-project/media-bundle  3.35.1      requires  jms/serializer-bundle (^2.3.1 || ^3.0)

@core23
Copy link
Member

core23 commented Nov 14, 2021

There was a release @phansys

https://github.com/FriendsOfSymfony/FOSRestBundle/releases/tag/3.1.0

@phansys phansys marked this pull request as ready for review November 14, 2021 20:28
@phansys phansys merged commit b164cc3 into sonata-project:3.x Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants