Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing methods to interfaces and abstract classes #2096

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Add missing methods to interfaces and abstract classes #2096

merged 1 commit into from
Sep 7, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Sep 6, 2021

Subject

Add missing methods to interfaces and abstract classes.

I am targeting this branch, because these changes respect BC.

Part of #2035.

Changelog

### Added
- Missing method declarations in interfaces and abstract classes, through `@method` annotation in order to respect BC.

@phansys phansys added the minor label Sep 6, 2021
@phansys phansys marked this pull request as ready for review September 6, 2021 23:03
@phansys phansys requested a review from a team September 6, 2021 23:03
@phansys phansys requested review from jordisala1991, VincentLanglet and a team September 7, 2021 09:04
@phansys phansys requested a review from a team September 7, 2021 09:26
@jordisala1991 jordisala1991 merged commit fe7b034 into sonata-project:3.x Sep 7, 2021
@jordisala1991
Copy link
Member

Thank you @phansys

@phansys phansys deleted the missing_methods branch September 7, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @jordisala1991 @VincentLanglet