Add CropResizer #1940
Merged
Add CropResizer #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
requested changes
Mar 18, 2021
core23
force-pushed
the
crop-resizer
branch
2 times, most recently
from
e3e8e8e to
dafb5d2
Compare
phansys
requested changes
Mar 18, 2021
|
Can you add some docs on how to use this new feature? |
Done |
phansys
approved these changes
Mar 19, 2021
VincentLanglet
approved these changes
Mar 19, 2021
wbloszyk
approved these changes
Mar 19, 2021
| @@ -1,6 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
| <parameters> | |||
| <parameter key="sonata.media.resizer.crop.class">Sonata\MediaBundle\Resizer\CropResizer</parameter> | |||
There was a problem hiding this comment.
IMO Will be nice to remove these parameters from xml and move it to the bundle configurator.
| new Reference('sonata.media.metadata.proxy'), | ||
| ]); | ||
| $definition->addTag('sonata.media.resizer'); | ||
| $container->setDefinition('sonata.media.resizer.crop', $definition); |
There was a problem hiding this comment.
Can we create sonata.media.resizer.base_crop for default class and sonata.media.resizer.crop alias for service or class configured by users?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Adds a new resizer that is similar to the existing
SquareResizer, but the result can have any image ratio.The new resizer can crop the Image to a given ratio. When given an Image with 1200 x 700 and you want an image with the format 100 x 70, the resizer will first scale the image down to 120 x 70 and then crops the remaining parts down to 100 x 70.
I am targeting this branch, because this feature is BC.
Changelog