Fix guessing mime type in AmazonMetadataBuilder #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
core23
previously approved these changes
Nov 18, 2020
jorrit
force-pushed
the
amazon-mimetype-bugfix
branch
from
e7e1c78 to
3938f56
Compare
phansys
reviewed
Nov 18, 2020
phansys
requested changes
Nov 18, 2020
phansys
reviewed
Nov 18, 2020
jorrit
force-pushed
the
amazon-mimetype-bugfix
branch
from
3938f56 to
5795952
Compare
VincentLanglet
previously approved these changes
Nov 18, 2020
core23
previously approved these changes
Nov 18, 2020
jorrit
force-pushed
the
amazon-mimetype-bugfix
branch
from
5795952 to
af98924
Compare
VincentLanglet
approved these changes
Nov 18, 2020
core23
approved these changes
Nov 18, 2020
phansys
approved these changes
Nov 18, 2020
|
Thanks ! @jorrit |
|
Ok @franmomu, I requested a new release for SonataMediaBundle via Slack in If you want to get notified about new releases, make sure to follow SonataNews on Twitter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
AmazonMetadataBuilder->getContentType()should not try to access the$filenameparameter as a local file because it has been uploaded already to S3.I am targeting this branch, because it's fixing a regression.
Closes #1854.
Changelog