Skip to content

Small refactoring of translations files #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2020
Merged

Small refactoring of translations files #1863

merged 1 commit into from
Nov 15, 2020

Conversation

gremo
Copy link
Contributor

@gremo gremo commented Nov 15, 2020 •
edited
Loading

Subject

I am targeting this branch, because this is a small improvement.

Changelog

### Added

- Comments in `GalleryAdmin.php` for the next-major translations refactoring

### Changed

- `SonataMediaBundle.de.xliff` re-arranged translation keys

### Fixed

- `SonataMediaBundle.it.xliff` fixed "gallery" and "Gallery" translations (case)

@gremo gremo mentioned this pull request Nov 15, 2020
Closed
@VincentLanglet VincentLanglet requested a review from a team November 15, 2020 11:32
@greg0ire greg0ire merged commit f7d4388 into sonata-project:3.x Nov 15, 2020
@greg0ire
Copy link
Contributor

Thanks @gremo !

@gremo gremo deleted the translations-gallery-fix branch November 16, 2020 07:37
@franmomu franmomu added the patch label Nov 30, 2020
@franmomu franmomu mentioned this pull request Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gremo @greg0ire @core23 @VincentLanglet @franmomu