Stop using SonataAdmin config in doctrineORMAdmin#1427
Conversation
|
I need to wait for sonata-project/SonataAdminBundle#7127 And, @dmaicher, I need to this AFTER the |
Then we should give https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/3.x/src/SonataDoctrineORMAdminBundle.php#L30 a lower priority than 0 so it comes after https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/SonataAdminBundle.php#L55. Like $container->addCompilerPass(new AddTemplatesCompilerPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -1); |
|
Need SonataAdmin 3.98.2 |
| ->end() | ||
| // NEXT_MAJOR: Remove this option. | ||
| ->arrayNode('filter') | ||
| ->setDeprecated('The "%node%" option is deprecated since sonata-project/admin-bundle 3.x.') |
There was a problem hiding this comment.
package name should be changed to the orm bundle, same above
dmaicher
left a comment
There was a problem hiding this comment.
LGTM except for the deprecation message namings mentioned by @jordisala1991
And we need to release this soon as without it admin release 3.98.2 is a bit broken for ORM users
Subject
I am targeting this branch, because BC.
Changelog