Try to fix Simple pager#1425
Merged
Merged
Conversation
Member
Author
|
But @franmomu can you tried my fix on your project ? |
Member
👍 looks like it works fine |
Member
Author
|
Please review @sonata-project/contributors |
It checks that the number of results from Pager must be the same as using Simple Pager
Member
Author
|
I also like to release this bugfix @dmaicher |
dmaicher
approved these changes
May 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because bugfix.
It could technically be considered as a BC-break since
executemethod is now returning aPaginatorinstead of anarray. But the phpdoc were sayingmixedso I don't think there is a real BC-promise about the returning value.It's still Countable and Traversable, and this is the only solution I found.
Closes #1403.
Changelog