Pass option by_reference in case we're using AdminType#1142
Merged
Conversation
Member
Author
|
Please review @sonata-project/contributors |
core23
requested changes
Oct 8, 2020
| public function getDefaultOptions($type, FieldDescriptionInterface $fieldDescription) | ||
| { | ||
| // NEXT_MAJOR: Remove this line and update the function signature. | ||
| $formOptions = \func_get_args()[2] ?? []; |
Member
There was a problem hiding this comment.
Can you add phpdoc for the new parameter? Maybe use @phpstan-param if the php-cs-fixer removes this.
Member
Author
There was a problem hiding this comment.
@core23 The phpdoc is inherited from the interface getDefaultOptions.
I prefer to add the phpdoc in the interface in the SonataAdmin PR https://github.com/sonata-project/SonataAdminBundle/pull/6438/files
core23
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
Related to sonata-project/SonataAdminBundle#6438
Then I'll need a release to add a conflict on SonataAdmin.
Changelog