Skip to content
This repository was archived by the owner on Jul 28, 2022. It is now read-only.

Add FieldDescriptionInterface#239

Closed
VincentLanglet wants to merge 9 commits intosonata-project:masterfrom
VincentLanglet:fieldDescription
Closed

Add FieldDescriptionInterface#239
VincentLanglet wants to merge 9 commits intosonata-project:masterfrom
VincentLanglet:fieldDescription

Conversation

@VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented May 31, 2020

Subject

Related to
#234
#233

I'm trying here

  • To move a (smaller) FieldDescriptionInterface from AdminBundle to DatagridBundle in order to use it.
  • To stop duplicating Datagrid/DatagridInterface/Filter/FilterInterface between AdminBundle and DatagridBundle. In the next major, AdminBundle will use the DatagridBundle classes.

I'm also trying to stop to be Doctrine-related in the DatagridBundle and the AdminBundle

  • By exposing FieldMappingInterface and AssociationMappingInterface instead of array with specific key.
  • By exposing AssociationMappingInterface constants instead of ClassMetadata ones.
    DoctrineORMAdminBundle will then do the mapping between our classes and the doctrine ones.

Steps are

  • Merge into master
  • Require datagrid-bundle@dev-master in admin-bundle@dev-master
  • Use/Extends the Datagrid interfaces in the AdminBundle
  • Remove some of the AdminBundle interface

Changelog

No changelog since it's on master, but I added an upgrade note.

TODO

@VincentLanglet
Copy link
Member Author

@core23 @phansys @greg0ire WDYT about this solution ?

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants