Extract magic numbers#7102
Merged
jordisala1991 merged 1 commit intosonata-project:3.xfrom Apr 21, 2021
Merged
Conversation
Member
Then we should add a NEXT_MAJOR comment to update them during the merge into master, no ? |
Member
Author
|
hmmm I think there is no need, during the merge it will be a conflict and we have to update accordingly, I'll do it. |
VincentLanglet
approved these changes
Apr 21, 2021
phansys
approved these changes
Apr 21, 2021
jordisala1991
approved these changes
Apr 21, 2021
Member
|
Thank you @franmomu |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also restores the defaults values from
3.xfor4.x.