Fix multiple psalm level 3 issues#7040
Merged
VincentLanglet merged 6 commits intosonata-project:masterfrom Apr 20, 2021
VincentLanglet:psalm3
Merged
Fix multiple psalm level 3 issues#7040VincentLanglet merged 6 commits intosonata-project:masterfrom VincentLanglet:psalm3
VincentLanglet merged 6 commits intosonata-project:masterfrom
VincentLanglet:psalm3
Conversation
Collaborator
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
previously approved these changes
Apr 14, 2021
Collaborator
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
previously approved these changes
Apr 16, 2021
franmomu
reviewed
Apr 16, 2021
jordisala1991
previously approved these changes
Apr 17, 2021
franmomu
reviewed
Apr 17, 2021
jordisala1991
previously approved these changes
Apr 18, 2021
franmomu
reviewed
Apr 18, 2021
jordisala1991
approved these changes
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't fix all the psalm level 3 issue but I think it's big enough for a PR.