Skip to content

LockInterface extends from ModelManagerInterface #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OskarStark merged 1 commit into from
Apr 30, 2020
Merged

LockInterface extends from ModelManagerInterface #6017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,7 @@ The Twig filters that come with the bundle will no longer load a default templat
The `sonata_admin` twig extension is now final. You may no longer extend it.

## SimplePager
Method `SimplePager::getResults` is always returning an array
Method `SimplePager::getResults` is always returning an array

## LockInterface
`LockInterface` extends from `ModelManagerInterface`.
2 changes: 1 addition & 1 deletion src/Model/LockInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* @author Emmanuel Vella <vella.emmanuel@gmail.com>
*/
interface LockInterface
interface LockInterface extends ModelManagerInterface
{
/**
* @param object $object
Expand Down
2 changes: 1 addition & 1 deletion tests/Admin/Extension/LockExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ private function configureFormMapper(): FormMapper
private function configureAdmin(
?string $uniqid = null,
?Request $request = null,
$modelManager = null
ModelManagerInterface $modelManager = null
): void {
$this->admin->getUniqid()->willReturn($uniqid);
$this->admin->getRequest()->willReturn($request);
Expand Down