Fix argument type passed to generateMenuUrl()#6011
Merged
greg0ire merged 1 commit intosonata-project:3.xfrom Apr 1, 2020
Merged
Fix argument type passed to generateMenuUrl()#6011greg0ire merged 1 commit intosonata-project:3.xfrom
generateMenuUrl()#6011greg0ire merged 1 commit intosonata-project:3.xfrom
Conversation
core23
previously approved these changes
Mar 31, 2020
core23
previously approved these changes
Mar 31, 2020
phansys
changed the title
generateMenuUrl()generateMenuUrl()
phansys
force-pushed
the
absolute_url
branch
3 times, most recently
from
9e6145c to
cc1468a
Compare
phansys
changed the title
generateMenuUrl()generateMenuUrl()
Member
Author
|
I think it's finally ready to merge. |
greg0ire
reviewed
Mar 31, 2020
greg0ire
reviewed
Mar 31, 2020
greg0ire
approved these changes
Mar 31, 2020
core23
requested changes
Apr 1, 2020
core23
approved these changes
Apr 1, 2020
Contributor
|
Thanks @phansys ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
Fix type of argument 3 passed to
UrlGeneratorInterface::generateMenuUrl().I am targeting this branch, because this change respects BC.
Changelog
To do