Skip to content

feat(form-theme): add label_translation_parameters support#5820

Closed
fancyweb wants to merge 1 commit intosonata-project:3.xfrom
fancyweb:label-translation-parameters
Closed

feat(form-theme): add label_translation_parameters support#5820
fancyweb wants to merge 1 commit intosonata-project:3.xfrom
fancyweb:label-translation-parameters

Conversation

@fancyweb
Copy link
Copy Markdown
Contributor

@fancyweb fancyweb commented Jan 6, 2020

Subject

Use the "label_translation_parameters" when translating form labels. This new feature was introduced in Symfony 4.3.

I am targeting this branch, because it adds support for a currently unsupported feature but in a backward compatible way.

Changelog

### Added
- Added support for the `label_translation_parameters` option in the form theme.

Use the "label_translation_parameters" when translating form labels. This new
feature was introduced in Symfony 4.3.
@phansys phansys added the minor label Jan 6, 2020
@phansys phansys requested a review from a team January 6, 2020 16:18
@phansys
Copy link
Copy Markdown
Member

phansys commented Jan 6, 2020

Should not the trans() calls at filter_admin_fields.html.twig be updated too?

{{ child.vars.label|trans({}, translation_domain) }}

{{ label|trans({}, translation_domain) }}

@VincentLanglet
Copy link
Copy Markdown
Member

Hi @fancyweb, do you have time to finish your PR ? :)

@fancyweb
Copy link
Copy Markdown
Contributor Author

@VincentLanglet I forgot about this one 😅 Do you want to finish this PR?

@VincentLanglet
Copy link
Copy Markdown
Member

@VincentLanglet I forgot about this one 😅 Do you want to finish this PR?

Maybe later, but I won't have time ATM.

But I was just looking for an answer to the @phansys question. There is maybe nothing to add.

@VincentLanglet
Copy link
Copy Markdown
Member

Closing in favor of #6206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants