Skip to content

Fixed wrong method call in "list__select.html.twig" #3897

Merged
OskarStark merged 1 commit intosonata-project:3.xfrom
core23:patch/list-select-2
May 31, 2016
Merged

Fixed wrong method call in "list__select.html.twig" #3897
OskarStark merged 1 commit intosonata-project:3.xfrom
core23:patch/list-select-2

Conversation

@core23
Copy link
Member

@core23 core23 commented May 30, 2016

Changelog

### Fixed
- Fixed wrong method call in `list__select.html.twig`. 

Subject

Fixed bug introduced with #3887. The wrong method was used.

@greg0ire
Copy link
Contributor

greg0ire commented May 30, 2016

The route is good, but the method isn't. The message should read:

Use object-unaware method

We have no object to pass to generateObjectUrl().

@core23 core23 force-pushed the patch/list-select-2 branch from 864ac1b to 45341e1 Compare May 31, 2016 18:23
@core23 core23 changed the title Fixed wrong route in "list__select.html.twig" Fixed wrong method call in "list__select.html.twig" May 31, 2016
@core23
Copy link
Member Author

core23 commented May 31, 2016

Fixed it @greg0ire

@soullivaneuh
Copy link
Member

@core23 Test will fail because of #3899. Please rebase. 👍

@OskarStark
Copy link
Member

Thank you @core23 👍

@OskarStark OskarStark merged commit 38eda83 into sonata-project:3.x May 31, 2016
@core23 core23 deleted the patch/list-select-2 branch May 31, 2016 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants