set alias default translation strategy#3572
Conversation
|
ping @rande |
|
Would fix #2419 very simply :) 👍 |
|
@andrey1s i would like to merge your PR, but could you please add a test that the configuration is processed correctly? Thank you! |
|
@OskarStark I don't use the Sonata configuration, only the configuration of the Symfony 2. and create alias for the default strategy. I think the configuration for the Sonata this could be another PR if needed. |
|
There is a problem with this though : you cannot associate a strategy with a given bundle. So, if you're using SonataUserBundle, changing the strategy will break all the translations and you will have to translate every string from this bundle again. See #3319 |
|
@greg0ire this PR not changing the default strategy. And of course if the developer changes the strategy then of course he needs to translate. |
Yes, it's the problem I'm warning you about. It would be better to be able to change the default strategy for a set of bundles only. |
|
But maybe this could be merged anyway, with a warning about this problem in the docs? It would be useful for people who only use the Admin Bundle I guess… |
|
|
||
| services: | ||
| sonata.admin.label.strategy.default: | ||
| alias: sonata.admin.label.strategy.underscore |
There was a problem hiding this comment.
Please add a warning that was mentioned by @greg0ire
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
5 participants
No description provided.