Review pr 1984 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend kernel argument handling to add support for the work_group_memory extension, allowing users to dynamically allocate local memory for a kernel. Signed-off-by: Lukas Sommer <[email protected]>
1. Save test SPV filename into a variable
2. Add static assert that SIZE must be divisible by 10
3. Replaced hard-coded expected value with one that depends on SIZE
4. Fixed typos in the source code to generate SPV files
a. Use #include <sycl/sycl.hpp>
b. Add missing instantiation for uint16_t
Similar to test file for local_accessor, add tests for work_group_memory
…uments LocalAccessor(ndim, elemental_type_str, dim0, dim1, dim2) The elemental type can be one of the following: "i1", "u1", "i2", "u2", "i4", "u4", "i8", "u8", "f4", "f8"
7 tasks
sommerlukas
force-pushed
the
work_group_memory
branch
from
b952f90 to
04efec6
Compare
sommerlukas
force-pushed
the
work_group_memory
branch
2 times, most recently
from
2eaf453 to
13cbd01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of work-group-memory PR.
It adds C and Python tests for WorkGroupMemory.
It fixes some errors, and export LocalAccessor type to be able to specify local accessor as
kernel argument for kernel submission.