Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new global search params (vault_scope and entities_match) #414

Merged
merged 8 commits into from
May 5, 2022
Merged

add new global search params (vault_scope and entities_match) #414

merged 8 commits into from
May 5, 2022

Conversation

davecap
Copy link
Member

@davecap davecap commented May 5, 2022 •
edited
Loading

  • Adds missing global search params (vault_scope, entities_match)
  • Fix issue with querying objects directly from search results
  • Fix issue with test environment dependencies

@davecap davecap requested a review from krivi95 May 5, 2022 17:37
krivi95
krivi95 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@krivi95 krivi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Only to add vault_scope and entities_match to the docstring of the contructor.

@davecap
Copy link
Member Author

davecap commented May 5, 2022

Also fixes issue with running result.query() directly on a constructed Global Search result.

@davecap
Copy link
Member Author

davecap commented May 5, 2022

Also fixes this: plotly/dash#1992

@davecap davecap merged commit a76e656 into master May 5, 2022
@davecap davecap deleted the add-new-search-params branch May 5, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivi95 krivi95 krivi95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davecap @krivi95