-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Qt to 6.8.1 to sync with github workflow #172
Conversation
…longer on qt download site.
Thanks. Could you please also fix the macos CI run? |
Sure, let me check what happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please prefer explicit OS version for CI.
.github/workflows/shunit2_runner.yml
Outdated
@@ -7,7 +7,7 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
strategy: | |||
matrix: | |||
os: [ubuntu-20.04, macos-12] | |||
os: [ubuntu-20.04, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an explicit version, not -latest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yungyuc
This is also used in other workflows of this repo. Although they are disabled, do you want to change them to use explicit version as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is explicitly specified to use "macos-15" now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, the CI is running against macos-13, macOS-14, macos-15. 13 and 14 are in alignment with modmesh workflow, and 15 is the latest macos and in alignment with my dev environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like it to be with macos-15 only. The simple unit tests cannot cover all build scenarios and it's better to keep it simple at the moment.
a82cbb1
to
96c1dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the macos versions to test to only v15.
This PR is to address issue #171 . The Qt version in the build script is upgraded to 6.8.1 in alignment with GitHub workflow in modmesh.