Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Qt to 6.8.1 to sync with github workflow #172

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

xingularity
Copy link
Contributor

This PR is to address issue #171 . The Qt version in the build script is upgraded to 6.8.1 in alignment with GitHub workflow in modmesh.

@yungyuc
Copy link
Member

yungyuc commented Jan 11, 2025

Thanks. Could you please also fix the macos CI run?

@yungyuc yungyuc added the enhancement New feature or request label Jan 11, 2025
@xingularity
Copy link
Contributor Author

Thanks. Could you please also fix the macos CI run?

Sure, let me check what happened.

Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefer explicit OS version for CI.

@@ -7,7 +7,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04, macos-12]
os: [ubuntu-20.04, macos-latest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an explicit version, not -latest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yungyuc

This is also used in other workflows of this repo. Although they are disabled, do you want to change them to use explicit version as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is explicitly specified to use "macos-15" now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, the CI is running against macos-13, macOS-14, macos-15. 13 and 14 are in alignment with modmesh workflow, and 15 is the latest macos and in alignment with my dev environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like it to be with macos-15 only. The simple unit tests cannot cover all build scenarios and it's better to keep it simple at the moment.

Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the macos versions to test to only v15.

@yungyuc yungyuc merged commit 84a570e into solvcon:main Jan 12, 2025
2 checks passed
@yungyuc yungyuc mentioned this pull request Jan 12, 2025
@yungyuc yungyuc linked an issue Jan 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt-6.6.3 outdated
2 participants